xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Joanna Rutkowska <joanna@invisiblethingslab.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Does xc_map_foreign_pages() update IOMMU tables?
Date: Thu, 13 May 2010 13:27:36 +0100	[thread overview]
Message-ID: <C811AEC8.14295%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4BEBEC09.1010503@invisiblethingslab.com>

On 13/05/2010 13:09, "Joanna Rutkowska" <joanna@invisiblethingslab.com>
wrote:

>> Seeing as how xc_map_foreign_pages() maps pages into a particular
>> guest-process virtual address space, whereas IOMMU tables are a mapping from
>> guest-physical address space, it's clear that x_m_f_p() cannot sensibly be
>> having any effect on the IOMMU.
>> 
> Interesting. That suggests the graphics drivers we tested do not use DMA
> for XShmPutImage()...

Ah, actually dom0 is special in that it gets a 1:1 mapping of all of RAM
(except for some private Xen areas). See
drivers/passthrough/vtd/x86/vtd.c:iommu_set_dom0_mapping(). I forgot about
that when I wrote my previous reply!

> Anyway, what would be the recommend way of updating IOMMU mappings in
> this case? Would you consider patching of x_m_f_p() an acceptable
> solution? (perhaps with some additional flag: "update_iommu")?

Like I said, the concept does not make sense: IOMMU tables and host page
tables map from different address spaces. But of course this does not matter
anyway given dom0 gets a pretty comprehensive mapping set up by default. So
I think you are good to go.

 -- Keir

  reply	other threads:[~2010-05-13 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 11:48 Does xc_map_foreign_pages() update IOMMU tables? Joanna Rutkowska
2010-05-13 12:00 ` Keir Fraser
2010-05-13 12:09   ` Joanna Rutkowska
2010-05-13 12:27     ` Keir Fraser [this message]
2010-05-13 12:39       ` Joanna Rutkowska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C811AEC8.14295%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=joanna@invisiblethingslab.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).