Re: [PATCH] fix save or snapshot at kernel loading time with HVM vm

[Keir Fraser <keir.fraser@eu.citrix.com>]

On 17/05/2010 06:57, "James (song wei)" <jsong@novell.com> wrote:

> 
> If doing save or snapshot at the time of kernel loading of a HVN vm,
> event_channel haven't been initialized, so that make this saving with
> xenstore. a string named "suspend" not "suspended"  will be sent to xend
> from checkpoint thread.
>  But in the shutdown function with parameter "suspend" think this request
> should shutdown this hvm guest, but obviously, this is not the expectation
> of save or  snapshot.

I don't really understand this patch comment, and the solution just looks
like a poor hack which noone in future will be able to fathom.

 -- Keir

> -James (Song Wei)
> 
> Signed-off-by:James (Song Wei) <jsong@novell.com>
> diff -r baccadfd9418 tools/python/xen/xend/XendDomainInfo.py
> --- a/tools/python/xen/xend/XendDomainInfo.py   Fri May 14 08:05:05 2010
> +0100
> +++ b/tools/python/xen/xend/XendDomainInfo.py   Mon May 17 13:56:15 2010
> +0800
> @@ -530,7 +530,7 @@
>          self.storeDom("control/shutdown", reason)
>  
>          # HVM domain shuts itself down only if it has PV drivers
> -        if self.info.is_hvm():
> +        if self.info.is_hvm() and reason != 'suspend':
>              hvm_pvdrv = xc.hvm_get_param(self.domid,
> HVM_PARAM_CALLBACK_IRQ)
>              hvm_s_state = xc.hvm_get_param(self.domid,
> HVM_PARAM_ACPI_S_STATE)
>              if not hvm_pvdrv or hvm_s_state != 0: