From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Roger Cruz <roger.cruz@virtualcomputer.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: ACPI suspend/resume on Dell Inspirons 1464/1564/1764
Date: Wed, 19 May 2010 20:24:12 +0100 [thread overview]
Message-ID: <C819F96C.1FBE%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <EACA7CA90354A849B1315959042A052C26F37A@BE24.exg4.exghost.com>
On 19/05/2010 17:36, "Roger Cruz" <roger.cruz@virtualcomputer.com> wrote:
> else
> {
> v->arch.hvm_vmx.secondary_exec_control &= ~SECONDARY_EXEC_ENABLE_EPT;
> vmx_vmexit_control &= ~(VM_EXIT_SAVE_GUEST_PAT |
> VM_EXIT_LOAD_HOST_PAT);
> vmx_vmentry_control &= ~VM_ENTRY_LOAD_GUEST_PAT;
> }
This is the bug. construct_vmcs() should make local copies of
vmx_vmexit_control and vmx_vmentry_control, and only clear bits in those
local copies. It should then __vmwrite() those local copies. I will make a
patch and apply to xen-unstable and xen-4.0 and xen-3.4.
Thanks,
Keir
next prev parent reply other threads:[~2010-05-19 19:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 22:25 ACPI suspend/resume on Dell Inspirons 1464/1564/1764 Roger Cruz
2010-05-04 22:52 ` Jeremy Fitzhardinge
2010-05-04 23:06 ` Roger Cruz
2010-05-12 18:38 ` Roger Cruz
2010-05-18 22:34 ` Roger Cruz
2010-05-19 7:25 ` Keir Fraser
2010-05-19 14:30 ` Roger Cruz
2010-05-19 14:50 ` Keir Fraser
2010-05-19 14:59 ` Keir Fraser
2010-05-19 16:36 ` Roger Cruz
2010-05-19 19:24 ` Keir Fraser [this message]
2010-05-19 19:41 ` Roger Cruz
2010-05-19 19:50 ` Roger Cruz
2010-05-19 19:54 ` Keir Fraser
2010-05-19 19:59 ` Roger Cruz
2010-05-19 19:26 ` Roger Cruz
-- strict thread matches above, loose matches on Subject: below --
2010-05-19 7:10 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C819F96C.1FBE%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=roger.cruz@virtualcomputer.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).