From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] ocaml: fix ocaml xc compilation on 32 bit
Date: Thu, 20 May 2010 14:13:38 +0100 [thread overview]
Message-ID: <C81AF412.14AF3%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1274360218.14939.2377.camel@zakaz.uk.xensource.com>
On 20/05/2010 13:56, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:
>>> - c_array = malloc(sizeof(xen_pfn_t) * c_nr_pfns);
>>> + c_array = malloc(sizeof(uint64_t) * c_nr_pfns);
>>
>> Wouldn't it be better to have here
>>
>> + c_array = calloc(c_nr_pfns, sizeof(uint64_t));
>
> I suppose so but that would be an unrelated change, please post a patch
> if you think it is worth it.
Who cares either way. calloc() has potential extra overhead for clearing the
memory, which is presumably not required in this case.
K.
prev parent reply other threads:[~2010-05-20 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 12:13 [PATCH] ocaml: fix ocaml xc compilation on 32 bit Ian Campbell
2010-05-20 12:24 ` Christoph Egger
2010-05-20 12:56 ` Ian Campbell
2010-05-20 13:13 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C81AF412.14AF3%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).