From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Tim Deegan <Tim.Deegan@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] HVM guests are allowed to use the entire virtual address space for
Date: Tue, 25 May 2010 16:11:52 +0100 [thread overview]
Message-ID: <C821A748.15464%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <C821A5A7.15454%keir.fraser@eu.citrix.com>
Put another way, I'd rather ASSERT(!is_hvm_vcpu(current)) than further
reinforce the current confusion around these macros by supporting an
obsolete usage.
-- Keir
On 25/05/2010 16:04, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
> I think this is already handled correctly by guest_access.h, which is what
> really matters. Nowadays copy_{to,from}_user (but not __copy_{to,from}_user)
> are mainly for private usage only by the guest-access macros, and just a few
> other arch-dependent PV_specific bits of code. Of course the __ versions are
> still generally useful as 'copy but catch any fault' functions.
>
> -- Keir
>
> On 25/05/2010 15:49, "Tim Deegan" <Tim.Deegan@citrix.com> wrote:
>
>> whatever they want, without any Xen hole. __addr_ok() is therefore
>> always true for such guests.
>>
>> Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com>
>>
>>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2010-05-25 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 14:49 [PATCH] HVM guests are allowed to use the entire virtual address space for Tim Deegan
2010-05-25 15:04 ` Keir Fraser
2010-05-25 15:11 ` Keir Fraser [this message]
2010-05-25 15:14 ` Tim Deegan
2010-05-25 16:24 ` Keir Fraser
2010-07-26 9:52 ` Paolo Bonzini
2010-07-26 10:00 ` Tim Deegan
2010-07-26 10:57 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C821A748.15464%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Tim.Deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).