From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Tim Deegan <Tim.Deegan@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] HVM guests are allowed to use the entire virtual address space for
Date: Tue, 25 May 2010 17:24:58 +0100 [thread overview]
Message-ID: <C821B86A.15476%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <20100525151432.GA15976@whitby.uk.xensource.com>
On 25/05/2010 16:14, "Tim Deegan" <Tim.Deegan@eu.citrix.com> wrote:
> At 16:04 +0100 on 25 May (1274803495), Keir Fraser wrote:
>> I think this is already handled correctly by guest_access.h, which is what
>> really matters. Nowadays copy_{to,from}_user (but not __copy_{to,from}_user)
>> are mainly for private usage only by the guest-access macros, and just a few
>> other arch-dependent PV_specific bits of code. Of course the __ versions are
>> still generally useful as 'copy but catch any fault' functions.
>
> OK, can I suggest the attached change instead? It brings the
> compat guest-handle macros in line with the normal ones.
Yeah, that's a good bug fix.
Thanks,
K.
next prev parent reply other threads:[~2010-05-25 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 14:49 [PATCH] HVM guests are allowed to use the entire virtual address space for Tim Deegan
2010-05-25 15:04 ` Keir Fraser
2010-05-25 15:11 ` Keir Fraser
2010-05-25 15:14 ` Tim Deegan
2010-05-25 16:24 ` Keir Fraser [this message]
2010-07-26 9:52 ` Paolo Bonzini
2010-07-26 10:00 ` Tim Deegan
2010-07-26 10:57 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C821B86A.15476%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Tim.Deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).