From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: treatment grant frames during save/restore
Date: Fri, 28 May 2010 09:22:06 +0100 [thread overview]
Message-ID: <C8253BBE.161EE%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4BFF947A0200007800004715@vpn.id2.novell.com>
On 28/05/2010 09:01, "Jan Beulich" <JBeulich@novell.com> wrote:
> Wouldn't is suffice to adjust XEN_DOMCTL_getpageframeinfo{2,3} to
> report these pages as special (not sure whether a new type would
> be needed, or whether simply returning XEN_DOMCTL_PFINFO_XTAB
> would be acceptable), thus allowing the tools to skip them as
> necessary? This of course implies that the tools would need to issue
> the call for HVM guests (currently I think they do so only for PV ones),
> that the actual page contents is irrelevant post-restore, and that
> there being a hole in the physical address space post-restore isn't
> a problem for the pv drivers.
Yep that would probably work. And also potentially gets rid of one lot of
"if-hvm-else-pv" branched code in xc_domain_save.c. I'd take a patch to do
that if you want to pick this item up.
-- Keir
next prev parent reply other threads:[~2010-05-28 8:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 15:27 treatment grant frames during save/restore Jan Beulich
2010-05-27 15:37 ` Jan Beulich
2010-05-27 15:50 ` Dan Magenheimer
2010-05-27 16:02 ` Keir Fraser
2010-05-28 8:01 ` Jan Beulich
2010-05-28 8:22 ` Keir Fraser [this message]
2010-05-31 14:58 ` Jan Beulich
2010-05-31 15:29 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8253BBE.161EE%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).