From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: treatment grant frames during save/restore Date: Fri, 28 May 2010 09:22:06 +0100 Message-ID: References: <4BFF947A0200007800004715@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4BFF947A0200007800004715@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 28/05/2010 09:01, "Jan Beulich" wrote: > Wouldn't is suffice to adjust XEN_DOMCTL_getpageframeinfo{2,3} to > report these pages as special (not sure whether a new type would > be needed, or whether simply returning XEN_DOMCTL_PFINFO_XTAB > would be acceptable), thus allowing the tools to skip them as > necessary? This of course implies that the tools would need to issue > the call for HVM guests (currently I think they do so only for PV ones), > that the actual page contents is irrelevant post-restore, and that > there being a hole in the physical address space post-restore isn't > a problem for the pv drivers. Yep that would probably work. And also potentially gets rid of one lot of "if-hvm-else-pv" branched code in xc_domain_save.c. I'd take a patch to do that if you want to pick this item up. -- Keir