From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: qemu-xen-unstable build error
Date: Fri, 28 May 2010 09:57:56 +0100
Message-ID: <C8254424.16203%keir.fraser@eu.citrix.com>
References: <789F9655DD1B8F43B48D77C5D30659731E78DA02@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E78DA02@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>, Zhigang Wang <zhigang.x.wang@oracle.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Perhaps it should also check against QEMU_TAG if defined, even if the
directory exists, and pull/checkout if necessary.

 K.

On 28/05/2010 09:53, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:

> I meet the issue just now. In the end I enter the ioemu-remote and do the
> branch/checkout manually.
> 
> When will the ioemu_remote be updated? Seems it will only be updated if this
> directory does not exist?
> 
>                 if [ ! -d ioemu-remote ]; then \
>                         rm -rf ioemu-remote ioemu-remote.tmp; \
>                         mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
>                         $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
>                         if [ "$(QEMU_TAG)" ]; then                      \
>                                 cd ioemu-remote.tmp;                    \
>                                 $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \
>                                 $(GIT) checkout -b dummy $(QEMU_TAG);   \
>                                 cd ..;                                  \
>                         fi;                                             \
>                         mv ioemu-remote.tmp ioemu-remote; \
> 
> Thanks
> --jyh
> 
>> -----Original Message-----
>> From: xen-devel-bounces@lists.xensource.com
>> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Keir Fraser
>> Sent: Friday, May 28, 2010 4:15 PM
>> To: Zhigang Wang; Ian Jackson
>> Cc: xen-devel
>> Subject: Re: [Xen-devel] qemu-xen-unstable build error
>> 
>> On 28/05/2010 08:23, "Zhigang Wang" <zhigang.x.wang@oracle.com> wrote:
>> 
>>> Seems this commit is incomplete:
>>> 
>>> commit ffb0cf2ad55e952dae55e6166c4fcea79be6cd30
>>> Author: Ian Jackson <ian.jackson@eu.citrix.com>
>>> Date:   Thu Apr 15 17:01:15 2010 +0100
>>> 
>>>     Change callers of libxc to use new libxc API.
>>> 
>>>     Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
>>> 
>>> I cannot find the definition of xc_interface.
>>> 
>>> Checkout to commit 805ed3b20492d2f4bb465bfda65cedd286e23209 can finish the
>>> build.
>> 
>> Perhaps your build is not respecting the QEMU_TAG in Config.mk, for some
>> reason? There are (humungous) patches pending on xen-unstable.hg which will
>> introduce xc_interface.
>> 
>> -- Keir
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel