From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1 Date: Sun, 30 May 2010 12:36:33 +0100 Message-ID: References: <20100530103753.GD17817@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20100530103753.GD17817@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pasi =?ISO-8859-1?B?S+Rya2vkaW5lbg==?= , eXeC001er Cc: Boris Derzhavets , Xen-devel List-Id: xen-devel@lists.xenproject.org On 30/05/2010 11:37, "Pasi K=E4rkk=E4inen" wrote: > On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote: >> I have already sent a patch 1 weak ago. (blktap2_control_func.patch) >> repeat in attach. >> Thanks. >=20 > Ok, thanks. >=20 > Keir: I guess this is not committed yet? I'm not too happy about the sleep(5). I guess if there's no better solution coming up I should just whack this patch in? -- Keir > -- Pasi >=20 >> 2010/5/30 Pasi K=E4rkk=E4inen <[1]pasik@iki.fi> >>=20 >> On Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote: >>> I've attempted to install Nexenta Core 3 image under Xen 4.0 >> (2.6.32.13 >>> pvops) on top of F13. Sample nexenta3.cfg profile contains 4 >> lines like >>> this:- >>>=20 >>> disk=3D['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from sample) >>>=20 >>> It generates message >>> =C2 File 'vhd:/path/.../disk.img' doesn't exist. >>>=20 >>> Boris. >>> P.S. It was already in one of the threads @xen-users. >>>=20 >>> This bug in "def _parse_uname(uname):" >> (tools/python/xen/util/blkif.py) >>> (taptype, fn) =3D fn.split(":", 1) >>>>>>=C2 (taptype, fn) =3D >> fn.split(":", >>> 2)[1:3] >>=20 >> Can you send a proper patch, as unified diff (diff -u), with a >> Signed-off-by line? >> -- Pasi >>=20 >> References >>=20 >> Visible links >> 1. mailto:pasik@iki.fi >=20 >> diff -r d0420ab97345 tools/python/xen/util/blkif.py >> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100 >> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400 >> @@ -87,7 +87,7 @@ >> fn =3D "/dev/%s" %(fn,) >> =20 >> if typ in ("tap", "tap2"): >> - (taptype, fn) =3D fn.split(":", 1) >> + (taptype, fn) =3D fn.split(":", 2)[1:] >> return (fn, taptype) >> =20 >> def blkdev_uname_to_file(uname): >> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py >> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 2010 += 0100 >> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 2010 += 0400 >> @@ -3292,6 +3292,7 @@ >> fn =3D BOOTLOADER_LOOPBACK_DEVICE >> =20 >> try: >> + time.sleep(5) >> blcfg =3D bootloader(blexec, fn, self, False, >> bootloader_args, kernel, ramdisk, ar= gs) >> finally: >> @@ -3299,7 +3300,7 @@ >> log.info("Unmounting %s from %s." % >> (fn, BOOTLOADER_LOOPBACK_DEVICE)) >> =20 >> - dom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEVIC= E) >> + dom0.destroyDevice(devtype, BOOTLOADER_LOOPBACK_DEV= ICE) >> =20 >> if blcfg is None: >> msg =3D "Had a bootloader specified, but can't find disk" >=20