From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Re: blktap2 problem with pvops kernel 2.6.32.13 and xen 4.0-rc1 Date: Sun, 30 May 2010 13:24:36 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: eXeC001er Cc: Boris Derzhavets , Xen-devel List-Id: xen-devel@lists.xenproject.org Needs a patch description and a signed-off-by line. -- Keir On 30/05/2010 13:21, "eXeC001er" wrote: > My python-experience=A0is small, but i tied to rewrite. > New in attach. >=20 > 2010/5/30 Keir Fraser >> On 30/05/2010 11:37, "Pasi K=E4rkk=E4inen" wrote: >>=20 >>> On Sun, May 30, 2010 at 02:02:06PM +0400, eXeC001er wrote: >>>> =A0 =A0I have already sent a patch 1 weak ago. (blktap2_control_func.patch= ) >>>> =A0 =A0repeat in attach. >>>> =A0 =A0Thanks. >>>=20 >>> Ok, thanks. >>>=20 >>> Keir: I guess this is not committed yet? >>=20 >> I'm not too happy about the sleep(5). I guess if there's no better solut= ion >> coming up I should just whack this patch in? >>=20 >> =A0-- Keir >>=20 >>> -- Pasi >>>=20 >>>> =A0 =A02010/5/30 Pasi K=E4rkk=E4inen <[1]pasik@iki.fi> >>>>=20 >>>> =A0 =A0 =A0On Sun, May 30, 2010 at 11:17:51AM +0400, eXeC001er wrote: >>>>> =A0 =A0 =A0I've attempted to install Nexenta Core 3 image under Xen 4.0 >>>> =A0 =A0 =A0(2.6.32.13 >>>>> =A0 =A0 =A0pvops) on top of F13. Sample nexenta3.cfg profile contains 4 >>>> =A0 =A0 =A0lines like >>>>> =A0 =A0 =A0this:- >>>>>=20 >>>>> =A0 =A0 =A0disk=3D['tat:tapdisk:vhd:/path/../disk.img,xvda,w'] ( from sample) >>>>>=20 >>>>> =A0 =A0 =A0It generates message >>>>> =A0 =A0 =A0=C2 File 'vhd:/path/.../disk.img' doesn't exist. >>>>>=20 >>>>> =A0 =A0 =A0Boris. >>>>> =A0 =A0 =A0P.S. It was already in one of the threads @xen-users. >>>>>=20 >>>>> =A0 =A0This bug in "def _parse_uname(uname):" >>>> =A0 =A0 =A0(tools/python/xen/util/blkif.py) >>>>> =A0 =A0(taptype, fn) =3D fn.split(":", 1) >>>>>>=C2 (taptype, fn) =3D >>>> =A0 =A0 =A0fn.split(":", >>>>> =A0 =A02)[1:3] >>>>=20 >>>> =A0 =A0 =A0Can you send a proper patch, as unified diff (diff -u), with a >>>> =A0 =A0 =A0Signed-off-by line? >>>> =A0 =A0 =A0-- Pasi >>>>=20 >>>> References >>>>=20 >>>> =A0 =A0Visible links >>>> =A0 =A01. mailto:pasik@iki.fi >>>=20 >>>> diff -r d0420ab97345 tools/python/xen/util/blkif.py >>>> --- a/tools/python/xen/util/blkif.py Fri May 21 16:21:39 2010 +0100 >>>> +++ b/tools/python/xen/util/blkif.py Sat May 22 01:21:15 2010 +0400 >>>> @@ -87,7 +87,7 @@ >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0fn =3D "/dev/%s" %(fn,) >>>>=20 >>>> =A0 =A0 =A0 =A0 =A0if typ in ("tap", "tap2"): >>>> - =A0 =A0 =A0 =A0 =A0 =A0(taptype, fn) =3D fn.split(":", 1) >>>> + =A0 =A0 =A0 =A0 =A0 =A0(taptype, fn) =3D fn.split(":", 2)[1:] >>>> =A0 =A0 =A0return (fn, taptype) >>>>=20 >>>> =A0def blkdev_uname_to_file(uname): >>>> diff -r d0420ab97345 tools/python/xen/xend/XendDomainInfo.py >>>> --- a/tools/python/xen/xend/XendDomainInfo.py Fri May 21 16:21:39 2010 >>>> +0100 >>>> +++ b/tools/python/xen/xend/XendDomainInfo.py Sat May 22 01:21:15 2010 >>>> +0400 >>>> @@ -3292,6 +3292,7 @@ >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0fn =3D BOOTLOADER_LOOPBACK_DEVICE >>>>=20 >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0try: >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0time.sleep(5) >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0blcfg =3D bootloader(blexec, fn, self, False, >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bootloader_args, kernel, ramdisk, = args) >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0finally: >>>> @@ -3299,7 +3300,7 @@ >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0log.info ("Unmounting %s from %= s." % >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (fn, BOOTLOADER_LOOPBACK_DEVICE)) >>>>=20 >>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dom0.destroyDevice('tap', BOOTLOADER_LOOPBACK_DEV= ICE) >>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0dom0.destroyDevice(devtype, >>>> BOOTLOADER_LOOPBACK_DEVICE) >>>>=20 >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0if blcfg is None: >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0msg =3D "Had a bootloader specified, but can't find dis= k" >>>=20 >>=20 >>=20 >=20 >=20