xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bug fix for "xen-hotplug-cleanup" script
@ 2010-06-06 20:26 eXeC001er
  2010-06-07  6:25 ` Keir Fraser
  0 siblings, 1 reply; 2+ messages in thread
From: eXeC001er @ 2010-06-06 20:26 UTC (permalink / raw)
  To: Xen-devel


[-- Attachment #1.1: Type: text/plain, Size: 220 bytes --]

Hi.

in log "/var/log/xen/xen-hotplug.log" i found error
"/etc/xen/scripts/xen-hotplug-cleanup: line 24: [: !=: unary operator
expected".

this patch for fix this bug:

Signed-off-by: eXeC001er <execooler@gmail.com>
---

[-- Attachment #1.2: Type: text/html, Size: 540 bytes --]

[-- Attachment #2: xen-hotplug-cleanup.patch --]
[-- Type: text/x-patch, Size: 609 bytes --]

diff -r 2c3495f3ca84 tools/hotplug/Linux/xen-hotplug-cleanup
--- a/tools/hotplug/Linux/xen-hotplug-cleanup	Fri Jun 04 10:50:55 2010 +0100
+++ b/tools/hotplug/Linux/xen-hotplug-cleanup	Mon Jun 07 00:23:24 2010 +0400
@@ -21,8 +21,8 @@
 
   # if the vm path does not exist and the device class is 'vbd' then we may have
   # a tap2 device
-  if [ $(xenstore-read "$vm_dev" 2>/dev/null) != "" ] \
-       && [ "${path_array[1]}" = "vbd" ]; then
+  if [ x$(xenstore-read "$vm_dev" 2>/dev/null) != "x" ] \
+       && [ x"${path_array[1]}" = "xvbd" ]; then
     vm_dev="$vm/device/tap2/${path_array[3]}"
   fi
 else

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bug fix for "xen-hotplug-cleanup" script
  2010-06-06 20:26 [PATCH] bug fix for "xen-hotplug-cleanup" script eXeC001er
@ 2010-06-07  6:25 ` Keir Fraser
  0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2010-06-07  6:25 UTC (permalink / raw)
  To: eXeC001er, Xen-devel

I backported xen-unstable:21129 to xen-4.0-testing, which appears to be an
existing alternative fix for this issue.

 Thanks,
 Keir

On 06/06/2010 21:26, "eXeC001er" <execooler@gmail.com> wrote:

> Hi.
> 
> in log "/var/log/xen/xen-hotplug.log" i found error
> "/etc/xen/scripts/xen-hotplug-cleanup: line 24: [: !=: unary operator
> expected".
> 
> this patch for fix this bug:
> 
> Signed-off-by: eXeC001er <execooler@gmail.com>
> ---
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-07  6:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-06 20:26 [PATCH] bug fix for "xen-hotplug-cleanup" script eXeC001er
2010-06-07  6:25 ` Keir Fraser

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).