From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] syslog support to xentoollog Date: Mon, 7 Jun 2010 07:51:35 +0100 Message-ID: References: <4C099F90.3080205@flexiant.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C099F90.3080205@flexiant.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Gihan Munasinghe , Ian Jackson Cc: "xen-devel@lists.xensource.com" , Stabellini Stefano List-Id: xen-devel@lists.xenproject.org On 05/06/2010 01:51, "Gihan Munasinghe" wrote: > Guys > > See the attach patch, this implements a xentoollog consumer that can log > in to syslog I'll wait for Ian to review this one before applying it. -- Keir > Following are the changes > > xentoollog.h: > 1) Generic, xtl_logger_set_minlevel and xtl_logger_adjust_flags > functions to be called from outside, > 2) Making logger flags to be more generic > 3) Change the struct xentool_logger, each logger will implement its own > "set_minlevel" and "adjust_flags" which will be invoked by > xtl_logger_set_minlevel and xtl_logger_adjust_flags generic functions. > 4) New function prototype to create a xentool_logger_syslogger > > Going forward I would like to suggest that xentoollog.h file should only > have generic functions, except for xtl_createlogger_* functions. Logger > type specific function should not be included(e.g > xtl_stdiostream_set_minlevel ) this will make sure outside code can > switch from one logger to another (from stdiologger to syslogger vice > versa) with out breaking the code. > > xtl_core.c: > 1) Implementation of xtl_logger_set_minlevel and xtl_logger_adjust_flags > functions. > > xtl_logger_syslog.c : > New logger implementation to log in to syslog. > > > I did some testing by changing the code in xl. This seems to work, but I > would really like if more people can test this. > Also could someone look @ the syslogger_progress function and add any > extra bits if needed, I did a very basic implementation of this. > > Signed-off-by : Gihan Munasinghe > > > Thanks > Gihan