From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Li, Xin" <xin.li@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: a compile error?
Date: Thu, 10 Jun 2010 10:20:45 +0100 [thread overview]
Message-ID: <C8366CFD.173B9%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD203C4EB2@shsmsx501.ccr.corp.intel.com>
On 10/06/2010 09:27, "Li, Xin" <xin.li@intel.com> wrote:
> the culprit snip is:
>
> if ( unlikely(now - s->next_second_time > SECONDS(86400)) )
> {
> dprintk(XENLOG_WARNING, "HVM RTC: dom %u skipping %llu seconds\n",
> ^^^^^^^^^
> vrtc_domain(s)->domain_id,
> (now - s->next_second_time) / SYSTEM_TIME_HZ);
> s->next_second_time = now;
> }
>
>
> Should we use PRIu64 here? I don't know if people using newer gcc don't see
> this as nobody complained.
Fixed by xen-unstable:21590.
Thanks,
Keir
prev parent reply other threads:[~2010-06-10 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 8:27 a compile error? Li, Xin
2010-06-10 9:20 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8366CFD.173B9%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=xin.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).