a compile error?

a compile error?

[Li, Xin]

I have been seeing a compile error with gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3) for several days:

rtc.c: In function `rtc_update_second':
rtc.c:294: warning: long long unsigned int format, long unsigned int arg (arg 5)
make[5]: *** [rtc.o] Error 1
make[5]: Leaving directory `/home/xin/xen-unstable.hg/xen/arch/x86/hvm'
make[4]: *** [hvm/built_in.o] Error 2
make[4]: Leaving directory `/home/xin/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/home/xin/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/home/xin/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/home/xin/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/home/xin/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/xin/xen-unstable.hg/xen'
make: *** [install-xen] Error 2

the culprit snip is:

    if ( unlikely(now - s->next_second_time > SECONDS(86400)) )
    {
        dprintk(XENLOG_WARNING, "HVM RTC: dom %u skipping %llu seconds\n",
													^^^^^^^^^
                vrtc_domain(s)->domain_id,
                (now - s->next_second_time) / SYSTEM_TIME_HZ);
        s->next_second_time = now;
    }


Should we use PRIu64 here?  I don't know if people using newer gcc don't see this as nobody complained.

Thanks!
-Xin

Re: a compile error?

[Keir Fraser]

On 10/06/2010 09:27, "Li, Xin" <xin.li@intel.com> wrote:

> the culprit snip is:
> 
>     if ( unlikely(now - s->next_second_time > SECONDS(86400)) )
>     {
>         dprintk(XENLOG_WARNING, "HVM RTC: dom %u skipping %llu seconds\n",
> ^^^^^^^^^
>                 vrtc_domain(s)->domain_id,
>                 (now - s->next_second_time) / SYSTEM_TIME_HZ);
>         s->next_second_time = now;
>     }
> 
> 
> Should we use PRIu64 here?  I don't know if people using newer gcc don't see
> this as nobody complained.

Fixed by xen-unstable:21590.

 Thanks,
 Keir