From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: a compile error?
Date: Thu, 10 Jun 2010 10:20:45 +0100
Message-ID: <C8366CFD.173B9%keir.fraser@eu.citrix.com>
References: <FC2FB65B4D919844ADE4BE3C2BB739AD203C4EB2@shsmsx501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD203C4EB2@shsmsx501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Li, Xin" <xin.li@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 10/06/2010 09:27, "Li, Xin" <xin.li@intel.com> wrote:

> the culprit snip is:
> 
>     if ( unlikely(now - s->next_second_time > SECONDS(86400)) )
>     {
>         dprintk(XENLOG_WARNING, "HVM RTC: dom %u skipping %llu seconds\n",
> ^^^^^^^^^
>                 vrtc_domain(s)->domain_id,
>                 (now - s->next_second_time) / SYSTEM_TIME_HZ);
>         s->next_second_time = now;
>     }
> 
> 
> Should we use PRIu64 here?  I don't know if people using newer gcc don't see
> this as nobody complained.

Fixed by xen-unstable:21590.

 Thanks,
 Keir