From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: RE: Bug in tmem: refcount leak leaves zombie saved domains
Date: Thu, 10 Jun 2010 17:34:40 +0100 [thread overview]
Message-ID: <C836D2B0.174C4%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4e50e2b3-6f87-47cc-88b5-b626a742cd74@default>
On 10/06/2010 16:38, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:
> Semi-related, rcu_lock_domain_by_id() has a "return d" inside
> the for loop without an rcu_read_unlock(). I see that this
> is irrelevant now because rcu_read_unlock() is a no-op anyway,
> but maybe this should be cleaned up for the same reason --
> in case rcu locking is ever fully implemented.
The implementation is correct. The matching rcu_read_unlock() is in
rcu_unlock_domain().
-- Keir
prev parent reply other threads:[~2010-06-10 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 9:46 Bug in tmem: refcount leak leaves zombie saved domains Keir Fraser
2010-06-10 13:08 ` Dan Magenheimer
2010-06-10 15:38 ` Dan Magenheimer
2010-06-10 16:12 ` Keir Fraser
2010-06-10 17:54 ` Dan Magenheimer
2010-06-10 20:06 ` Keir Fraser
2010-06-10 21:43 ` Keir Fraser
2010-06-10 22:34 ` Dan Magenheimer
2010-06-11 7:39 ` Jan Beulich
2010-06-10 16:34 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C836D2B0.174C4%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=dan.magenheimer@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).