From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] apic: clean up msr handling Date: Fri, 11 Jun 2010 16:57:58 +0100 Message-ID: References: <201006111751.49588.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201006111751.49588.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , "xen-devel@lists.xensource.com" Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org On 11/06/2010 16:51, "Christoph Egger" wrote: >> Hm, I didn't spot that one. It's odd since I thought Christoph was changign >> macros into inlien functions where possible. Maybe he just changes in >> whichever direction makes his patch bigger? ;-) > > No, this change has to do with 'smp_processor_id() undefined'. > The root problem is a circular dependency with inclusion of headers. > The right fix is to clean up the headers. Yep, that's what I did. -- Keir