From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86: fix pv cpuid masking Date: Wed, 16 Jun 2010 14:29:38 +0100 Message-ID: References: <4C18EBDF0200007800006AF8@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C18EBDF0200007800006AF8@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 16/06/2010 14:21, "Jan Beulich" wrote: >> What remains open is the question whether pv_cpuid() shouldn't also >> consume these masks. > > What is your opinion on this, Keir? Libxc/xc_cpuid_x86.c already applies the policy expressed in a domain's config file, plus its own internal policy, on top of physical host CPUID. Since host CPUID is already affected by the above-mentioned masks, I don't think anything further needs to be done. -- Keir