From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] svm: debug improvements
Date: Wed, 23 Jun 2010 14:48:28 +0100 [thread overview]
Message-ID: <C847CF3C.184AB%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <201006231449.41973.Christoph.Egger@amd.com>
On 23/06/2010 13:49, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> Attached patch moves vmcb dump function into
> its own svm debug files.
> Add svm_vmcb_isvalid() to svm code to validate
> the vmcb.
I won't take patches to add things that aren't used. Unless they are used
later in the same patch series, all posted with intention to be applied at
the same time. Otherwise the function is dead code, and I love to delete
dead code.
-- Keir
next prev parent reply other threads:[~2010-06-23 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 12:49 [PATCH] svm: debug improvements Christoph Egger
2010-06-23 13:48 ` Keir Fraser [this message]
2010-06-24 10:33 ` Christoph Egger
2010-06-24 12:20 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C847CF3C.184AB%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).