From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] svm: debug improvements Date: Wed, 23 Jun 2010 14:48:28 +0100 Message-ID: References: <201006231449.41973.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201006231449.41973.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/06/2010 13:49, "Christoph Egger" wrote: > Attached patch moves vmcb dump function into > its own svm debug files. > Add svm_vmcb_isvalid() to svm code to validate > the vmcb. I won't take patches to add things that aren't used. Unless they are used later in the same patch series, all posted with intention to be applied at the same time. Otherwise the function is dead code, and I love to delete dead code. -- Keir