Xen 4.0 is broken on 32bit

Xen 4.0 is broken on 32bit

[Huang2, Wei]

[-- Attachment #1.1: Type: text/plain, Size: 705 bytes --]

The changset 21229 breaks Xen 4.0.1 tree on 32bit environment. Starting a guest VM will throw out an error as "Error: (38, 'Function not implemented')". Apparently, the hypercall to mem_sharing_op is missing for 32bit environment due to 21229.  The following small patch can fix this issue.

Thanks,
-Wei



diff -r afe5a6a8b8df xen/arch/x86/domctl.c
--- a/xen/arch/x86/domctl.c     Fri Jul 02 22:04:32 2010 +0100
+++ b/xen/arch/x86/domctl.c     Wed Jul 07 11:51:26 2010 -0500
@@ -1449,6 +1449,11 @@
         }
     }
     break;
+#else
+    case XEN_DOMCTL_mem_event_op:
+    case XEN_DOMCTL_mem_sharing_op:
+        ret = 0;
+        break;
 #endif /* __x86_64__ */

     default:

[-- Attachment #1.2: Type: text/html, Size: 3523 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: Xen 4.0 is broken on 32bit

[Keir Fraser]

On 08/07/2010 00:04, "Huang2, Wei" <Wei.Huang2@amd.com> wrote:

> The changset 21229 breaks Xen 4.0.1 tree on 32bit environment. Starting a
> guest VM will throw out an error as ³Error: (38, ŒFunction not implemented¹)².
> Apparently, the hypercall to mem_sharing_op is missing for 32bit environment
> due to 21229.  The following small patch can fix this issue.

This will be the unconditional xc.dom_set_memshr() call in xend's image.py.
Should be wrapped in try-except.

 -- Keir

> Thanks,
> -Wei
>  
>  
>  
> diff -r afe5a6a8b8df xen/arch/x86/domctl.c
> --- a/xen/arch/x86/domctl.c     Fri Jul 02 22:04:32 2010 +0100
> +++ b/xen/arch/x86/domctl.c     Wed Jul 07 11:51:26 2010 -0500
> @@ -1449,6 +1449,11 @@
>          } 
>      }
>      break;
> +#else
> +    case XEN_DOMCTL_mem_event_op:
> +    case XEN_DOMCTL_mem_sharing_op:
> +        ret = 0;
> +        break;
>  #endif /* __x86_64__ */
>  
>      default:
> 

Re: Xen 4.0 is broken on 32bit

[Keir Fraser]

Should be fixed by xen-unstable:21751 and xen-4.0-testing:21258.

 -- Keir

On 08/07/2010 00:04, "Huang2, Wei" <Wei.Huang2@amd.com> wrote:

> The changset 21229 breaks Xen 4.0.1 tree on 32bit environment. Starting a
> guest VM will throw out an error as ³Error: (38, ŒFunction not implemented¹)².
> Apparently, the hypercall to mem_sharing_op is missing for 32bit environment
> due to 21229.  The following small patch can fix this issue.
>  
> Thanks,
> -Wei
>  
>  
>  
> diff -r afe5a6a8b8df xen/arch/x86/domctl.c
> --- a/xen/arch/x86/domctl.c     Fri Jul 02 22:04:32 2010 +0100
> +++ b/xen/arch/x86/domctl.c     Wed Jul 07 11:51:26 2010 -0500
> @@ -1449,6 +1449,11 @@
>          } 
>      }
>      break;
> +#else
> +    case XEN_DOMCTL_mem_event_op:
> +    case XEN_DOMCTL_mem_sharing_op:
> +        ret = 0;
> +        break;
>  #endif /* __x86_64__ */
>  
>      default:
>