xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: xen tsc problems?
Date: Tue, 13 Jul 2010 19:12:01 +0100	[thread overview]
Message-ID: <C8626B01.1A936%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <C8626573.1A92C%keir.fraser@eu.citrix.com>

On 13/07/2010 18:48, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

>> I started to wonder why the guest is seeing such a big tsc warp when xen
>> is seeing 0, so I added more tracing and eventually I found out that the
>> value of v->arch.hvm_vcpu.stime_offset is significantly different
>> between the two vcpus and the difference increases after the scaling.
>> Then I added timer_mode=1 to my vm config file and the problem went
>> away.
>> I think that delay_for_missed_ticks shouldn't cause tsc scew in
>> the guest.
> 
> Well, timer_mode=1 is the default and I doubt in all seriousness that the
> other modes get any use or testing.

To give you an idea how long it's probably been broken, my suspicion is that
the culprit is xen-unstable:17716, which is over two years old. That patch
changed HVM time handling to base it more on Xen system time. The fact that
hvm_set_guest_time() no longer directly affects guest TSC is probably the
problem here. I think delay_for_missed_ticks might depend on that. Anyway,
I'm not certain but I'd put money on it.

 -- Keir

      parent reply	other threads:[~2010-07-13 18:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 14:37 xen tsc problems? Stefano Stabellini
2010-07-13 14:43 ` Keir Fraser
2010-07-13 15:37   ` Dan Magenheimer
2010-07-13 17:39     ` Stefano Stabellini
2010-07-13 17:48       ` Keir Fraser
2010-07-13 18:06         ` Dan Magenheimer
2010-07-13 18:14           ` Stefano Stabellini
2010-07-13 18:59             ` Keir Fraser
2010-07-13 19:32               ` Dan Magenheimer
2010-07-13 18:12         ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8626B01.1A936%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).