From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] tools: gpxe build fix
Date: Wed, 21 Jul 2010 17:02:07 +0100 [thread overview]
Message-ID: <C86CD88F.1B40C%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <19527.5438.131099.513012@mariner.uk.xensource.com>
On 21/07/2010 16:41, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] tools: gpxe build fix"):
>> On NetBSD, uname -m prints 'amd64'.
>> Attached patch makes gpxe aware of that.
>
> Are there any other systems on which uname -m prints amd64 on which
> this patch will break ?
>
> I think calling a patch "Makefile.patch" is going to be annoying.
> And patches in a series should not be named just after the file they
> change as if only one patch touches each file.
>
> How about "makefile-amd64.patch" ?
>
> Also "gpxe build fix" is a hopeless commit message.
I ended up upgrading us to far more recent gpxe, where this whole issue has
simply disappeared.
-- Keir
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
prev parent reply other threads:[~2010-07-21 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 12:25 [PATCH] tools: gpxe build fix Christoph Egger
2010-07-20 7:50 ` Simon Horman
2010-07-21 15:41 ` Ian Jackson
2010-07-21 16:02 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C86CD88F.1B40C%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).