From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xenoprof: Cleanup
Date: Tue, 10 Aug 2010 17:13:33 +0100 [thread overview]
Message-ID: <C887393D.1D4FE%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <19553.30305.743166.641813@mariner.uk.xensource.com>
On 10/08/2010 16:55, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
> KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
>> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
> ...
>> -/* AMD IBS support */
>> -extern u32 ibs_caps;
>
> But, in xen/common/xenoprof.c, surely this should be a definition and
> not a declaration. So more correct would be
>
> -extern u32 ibs_caps;
> +u32 ibs_caps;
>
> but that would conflict with the #define in
> xen/include/asm-ia64/xenoprof.h. So I'm not sure this fix is complete.
It's defined in arch-specific arch/x86/oprofile/op_model_athlon.c. Exposed
to common/xenoprof.c in the arch-specific include/asm-x86/xenoprof.h (and
stubbed out in ia64's equivalent header).
-- Keir
prev parent reply other threads:[~2010-08-10 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 2:17 [PATCH] xenoprof: Cleanup KUWAMURA Shin'ya
2010-08-10 15:55 ` Ian Jackson
2010-08-10 16:13 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C887393D.1D4FE%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=kuwa@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).