From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] xenoprof: Cleanup
Date: Tue, 10 Aug 2010 17:13:33 +0100
Message-ID: <C887393D.1D4FE%keir.fraser@eu.citrix.com>
References: <19553.30305.743166.641813@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19553.30305.743166.641813@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, KUWAMURA Shin'ya <kuwa@jp.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 10/08/2010 16:55, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:

> KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
>> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
> ...
>> -/* AMD IBS support */
>> -extern u32 ibs_caps;
> 
> But, in xen/common/xenoprof.c, surely this should be a definition and
> not a declaration.  So more correct would be
> 
>  -extern u32 ibs_caps;
>  +u32 ibs_caps;
> 
> but that would conflict with the #define in
> xen/include/asm-ia64/xenoprof.h.  So I'm not sure this fix is complete.

It's defined in arch-specific arch/x86/oprofile/op_model_athlon.c. Exposed
to common/xenoprof.c in the arch-specific include/asm-x86/xenoprof.h (and
stubbed out in ia64's equivalent header).

 -- Keir