From: Keir Fraser <keir.fraser@eu.citrix.com>
To: George Dunlap <George.Dunlap@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Konrad Rzeszutek Wilk <konrad.wilk>
Subject: Re: IRQs, move_in_progress, -EBUSY &c
Date: Wed, 11 Aug 2010 16:04:40 +0100 [thread overview]
Message-ID: <C8887A98.445F%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <AANLkTin2Q9pH+v=Nm=T-R_sgajrdxKy5nj+_5Ja+Wb6Y@mail.gmail.com>
On 11/08/2010 15:56, "George Dunlap" <George.Dunlap@eu.citrix.com> wrote:
> However, it seems that moving IRQs is not handled properly. Either
> the pvops kernel should retry if it gets an -EBUSY, or the hypercall
> should not fail, but wait until it can return success.
Move_in_progress is a private hypervisor implementation detail. We shouldn't
make it visible to the guest via EBUSY. Worst case we should be turning the
retry into a hypercall continuation. Even better if we don't need to make
the IRQ bind request wait at all... Not sure why that needs to happen at
all.
-- Keir
> I discovered all this by adding debug statements to the IRQ path; the
> patch is attached, if anyone else wants to use it.
>
> -George
next prev parent reply other threads:[~2010-08-11 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 14:56 IRQs, move_in_progress, -EBUSY &c George Dunlap
2010-08-11 15:04 ` Keir Fraser [this message]
2010-08-11 15:38 ` Jeremy Fitzhardinge
2010-08-11 15:59 ` Keir Fraser
2010-08-11 17:49 ` George Dunlap
2010-08-11 18:18 ` Keir Fraser
2010-08-11 19:06 ` George Dunlap
2010-08-11 19:12 ` Keir Fraser
2010-08-11 19:52 ` George Dunlap
2010-08-11 19:28 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8887A98.445F%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).