Re: IRQs, move_in_progress, -EBUSY &c

[Keir Fraser <keir.fraser@eu.citrix.com>]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On 11/08/2010 15:56, "George Dunlap" <George.Dunlap@eu.citrix.com> wrote:

> However, it seems that moving IRQs is not handled properly.  Either
> the pvops kernel should retry if it gets an -EBUSY, or the hypercall
> should not fail, but wait until it can return success.

Can you try the attached patch?

 Thanks,
 Keir

> I discovered all this by adding debug statements to the IRQ path; the
> patch is attached, if anyone else wants to use it.
> 
>  -George


[-- Attachment #2: 00-gsi-retry --]
[-- Type: application/octet-stream, Size: 526 bytes --]

diff -r f45026ec8db5 xen/arch/x86/physdev.c
--- a/xen/arch/x86/physdev.c	Mon Aug 09 18:29:50 2010 +0100
+++ b/xen/arch/x86/physdev.c	Wed Aug 11 16:58:14 2010 +0100
@@ -478,6 +478,9 @@
             break;
         ret = mp_register_gsi(setup_gsi.gsi, setup_gsi.triggering,
                               setup_gsi.polarity);
+        if ( ret == -EBUSY ) /* IRQ is being moved */
+            ret = hypercall_create_continuation(
+                __HYPERVISOR_physdev_op, "ih", cmd, arg);
         break; 
     }
     default:

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel