From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dante Cinco <dantecinco@gmail.com>,
"wei.wang2@amd.com" <wei.wang2@amd.com>,
Xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] msi: Avoid uninitialized msi descriptors
Date: Wed, 11 Aug 2010 18:36:47 +0100 [thread overview]
Message-ID: <C8889E3F.1D70B%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <AANLkTi=uoWXLFOotTJEUB4ah7fAdJ7EZKE1Y6sJc96Ch@mail.gmail.com>
On 11/08/2010 18:09, "Dante Cinco" <dantecinco@gmail.com> wrote:
> I'm glad that somebody who is familiar with MSI has resolved this
> problem although I haven't applied and verified the proposed patch yet
> on my system. I posted the Xen crash I experienced related to this
> issue on xen-devel a couple of weeks ago (see link below) but wasn't
> familiar enough with the MSI/MSI-X code to propose a solution other
> than to back out changelist 21778.
Let me know when you confirm. I backported 21778 for 4.0.1, perhaps in too
much haste. If this is a good fix then I should backport it as well.
Thanks,
Keir
> http://old.nabble.com/Re:-(XEN)-RIP:-e008:-%3Cffff82c48015564b%3E---write_msi_
> msg%2B0x2b-0x150-p29301832.html
>
> Dante
>
>
> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Wei Wang2
> Sent: Wednesday, August 11, 2010 6:43 AM
> To: xen-devel@lists.xensource.com
> Subject: [Xen-devel] [PATCH] msi: Avoid uninitialized msi descriptors
>
> Hi,
> When __pci_enable_msix() returns early, output parameter (struct msi_desc
> **desc) will not be initialized. On my machine, a Broadcom BCM5709
> nic has both MSI and MSIX capability blocks and when guest tries to
> enable msix interrupts but __pci_enable_msix() returns early for
> encountering a msi block, the whole system will crash for fatal page
> fault immediately.
>
> Thanks,
> Wei
>
> Signed-off-by: Wei Wang <wei.wang2@amd.com>
> --
> AMD GmbH, Germany
> Operating System Research Center
>
> Legal Information:
> Advanced Micro Devices GmbH
> Karl-Hammerschmidt-Str. 34
> 85609 Dornach b. München
>
> Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht
> München, HRB Nr. 43632
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2010-08-11 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 17:09 [PATCH] msi: Avoid uninitialized msi descriptors Dante Cinco
2010-08-11 17:36 ` Keir Fraser [this message]
2010-08-12 13:30 ` Wei Wang2
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 13:43 Wei Wang2
2010-08-13 12:07 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8889E3F.1D70B%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=dantecinco@gmail.com \
--cc=wei.wang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).