xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Tim Deegan <Tim.Deegan@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 0 of 4] [RFC] x86 shadow: get rid of the need for contiguous memory
Date: Fri, 20 Aug 2010 17:49:25 +0100	[thread overview]
Message-ID: <C89470A5.1EA70%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1c49df37-75e0-41dc-ad3a-bf3119315826@default>

Hack up the vcpu dand domain structures and handle only being able to
allocate a single-page hypercall compat tranlsation page, and that might be
pretty much it.

 -- Keir

On 20/08/2010 17:29, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:

> ooohh!!  thank you thank you
> 
> /me wonders how many other order>0 allocations are left now
> that will break a running or newly-launching domain when the
> allocation fails due to fragmentation, and if it will be easy
> to track them down and shoot them
> 
>> -----Original Message-----
>> From: Tim Deegan [mailto:Tim.Deegan@citrix.com]
>> Sent: Friday, August 20, 2010 9:58 AM
>> To: xen-devel@lists.xensource.com
>> Subject: [Xen-devel] [PATCH 0 of 4] [RFC] x86 shadow: get rid of the
>> need for contiguous memory
>> 
>> 
>> This series of patches removes the need for shadow pagetable memory to
>> be allocated in 4-page contiguous blocks, by reusing the page_info
>> list header for yet one more thing.
>> 
>> It fixes a long-standing issue where on a fairly full machine which has
>> seen a lot of ballooning HVM domain creation can fail because the
>> remaining memory is too fragmented to use for shadows.
>> 
>> Posting as an RFC for now because I haven't had a chance to do any
>> heavy testing (compile tests under 32-bit WinXP seem fine though)
>> and I'm away for the next week.  I hope to fold in any feedback
>> and commit this change the week after that.
>> 
>> Cheers,
>> 
>> Tim.
>> 
>> 5 files changed, 332 insertions(+), 301 deletions(-)
>> xen/arch/x86/mm/shadow/common.c  |  345 +++++++++++++------------------
>> -------
>> xen/arch/x86/mm/shadow/multi.c   |  143 +++++++++------
>> xen/arch/x86/mm/shadow/private.h |  117 +++++++++++-
>> xen/include/asm-x86/domain.h     |    3
>> xen/include/asm-x86/mm.h         |   25 +-
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

      reply	other threads:[~2010-08-20 16:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20 15:57 [PATCH 0 of 4] [RFC] x86 shadow: get rid of the need for contiguous memory Tim Deegan
2010-08-20 15:58 ` [PATCH 1 of 4] x86 shadow: for multi-page shadows, explicitly track the first page Tim Deegan
2010-08-20 15:58 ` [PATCH 2 of 4] x86 shadow: explicitly link the pages of multipage shadows Tim Deegan
2010-08-20 15:58 ` [PATCH 3 of 4] x86 shadow: remove the assumption that multipage shadows are contiguous Tim Deegan
2010-08-20 15:58 ` [PATCH 4 of 4] x86 shadow: allocate all shadow memory in single pages Tim Deegan
2010-08-20 16:29 ` [PATCH 0 of 4] [RFC] x86 shadow: get rid of the need for contiguous memory Dan Magenheimer
2010-08-20 16:49   ` Keir Fraser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C89470A5.1EA70%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=Tim.Deegan@eu.citrix.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).