From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Huang2, Wei" <Wei.Huang2@amd.com>,
"Przywara, Andre" <Andre.Przywara@amd.com>,
Nitin Kamble <nitin.a.kamble@intel.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH] libxc: remove CPUID core information mangling
Date: Wed, 25 Aug 2010 16:39:04 +0100 [thread overview]
Message-ID: <C89AF7A8.1F0F9%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <EE335F95F28A664DB4A21289D2AA053B73E7FBE9@SAUSEXMBP01.amd.com>
I meant it should remain the old way, since HVM virtual APIC IDs are
vcpu_id*2.
-- Keir
On 25/08/2010 16:28, "Huang2, Wei" <Wei.Huang2@amd.com> wrote:
> Hi Keir,
>
> Do you mean that we should leave 80000008:ECX[15:12] as zero or in old way
> (i.e. (regs[2] & 0xf000u) + 1))? These bits can't be zero, unless we want to
> use legacy method in multi-core calculation.
>
> -Wei
>
> ========
> I think you shouldn't change handling of 80000008:ECX[15:12] since that does
> explicitly refer to APIC ID arrangement. The rest of your changes could be
> correct as far as I can tell from the reference manuals.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
next prev parent reply other threads:[~2010-08-25 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 12:04 [PATCH] libxc: remove CPUID core information mangling Andre Przywara
2010-08-25 12:42 ` Keir Fraser
2010-08-25 15:28 ` Huang2, Wei
2010-08-25 15:39 ` Keir Fraser [this message]
2010-08-25 15:53 ` Huang2, Wei
2010-08-25 16:00 ` Keir Fraser
2010-08-26 20:48 ` Andre Przywara
2010-08-25 15:25 ` [osrc-patches] " Huang2, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C89AF7A8.1F0F9%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Andre.Przywara@amd.com \
--cc=Wei.Huang2@amd.com \
--cc=nitin.a.kamble@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).