From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Xen-unstable panic: FATAL PAGE FAULT
Date: Wed, 1 Sep 2010 10:28:49 +0100
Message-ID: <C8A3DB61.21A1C%keir.fraser@eu.citrix.com>
References: <4C7E32A50200007800013A3F@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4C7E32A50200007800013A3F@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>, MaoXiaoyun <tinnycloud@hotmail.com>
Cc: xen devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 01/09/2010 10:01, "Jan Beulich" <JBeulich@novell.com> wrote:

>>>> On 01.09.10 at 10:49, Keir Fraser <keir.fraser@eu.citrix.com> wrote:
>> Okay, my next guess then is that we are deleting a chunk from the wrong list
>> head. I don't see any check that the adjacent chunks we are considering to
>> merge are from the same node and zone. I suppose the zone logic does just
>> work as we're dealing with 2**x aligned and sized regions. But, shouldn't
>> the merging logic in free_heap_pages be checking that the merging candidate
>> is from the same NUMA node? I see I have an ASSERTion later in the same
>> function, but it's too weak and wishful I suspect.
> 
> Hmm, we're keeping a page reserved if node boundaries aren't
> well aligned (at the end of init_heap_pages()), so that shouldn't
> be possible.

Oh yes, that ought to be sufficient really.

 -- Keir