From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: A simple clean up of __get_instruction_length & __update_guest_eip Date: Wed, 15 Sep 2010 16:38:23 +0100 Message-ID: References: <4C91018C02000078000165DD@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4C91018C02000078000165DD@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Eddie Dong Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 15/09/2010 16:25, "Jan Beulich" wrote: > Is it really a good idea to remove all these "Safe: ..." comments? > Without them, I think it'll be much easier to not remember that > this cannot be done everywhere and hence to add an inappropriate > call to this function. I meant to check they were kept, and then forgot and applied it anyway. I'll add them back in. --Keir