From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ? Date: Thu, 16 Dec 2010 20:34:50 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3375376497_47408197" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: George Dunlap , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3375376497_47408197 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 16/12/2010 17:03, "Keir Fraser" wrote: > On 16/12/2010 16:50, "Jan Beulich" wrote: > >>> approach therefore. Perhaps *(volatile type *)px = x or, really, even better >>> I should define some {read,write}_atomic{8,16,32,64} accessor functions >>> which use inline asm to absolutely definitely emit a single atomic 'mov' >>> instruction. >>> >>> Make sense? >> >> Yes. > > Excellent. I will lay groundwork and fix pte_{read,write}_atomic directly in > -unstable and -4.0-testing. I will then post a proposed fix for EPT to the > list. I don't know that code so well and I may not otherwise catch all > places that require use of the new accessor macros. Attached is a patch I've knocked up for p2m-ept.c. I don't know how complete it really is. Perhaps someone (George?) would like to Ack it as is, or develop it further. -- Keir > -- Keir > >> Jan >> > > --B_3375376497_47408197 Content-type: application/octet-stream; name="00-ept-atomic" Content-disposition: attachment; filename="00-ept-atomic" Content-transfer-encoding: base64 ZGlmZiAtciBmNWYzY2Y0ZTAwMWYgeGVuL2FyY2gveDg2L21tL2hhcC9wMm0tZXB0LmMKLS0t IGEveGVuL2FyY2gveDg2L21tL2hhcC9wMm0tZXB0LmMJVGh1IERlYyAxNiAyMDowNzowMyAy MDEwICswMDAwCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9oYXAvcDJtLWVwdC5jCVRodSBEZWMg MTYgMjA6Mjk6MDEgMjAxMCArMDAwMApAQCAtMzIsNiArMzIsMTEgQEAKICNpbmNsdWRlIDx4 ZW4va2V5aGFuZGxlci5oPgogI2luY2x1ZGUgPHhlbi9zb2Z0aXJxLmg+CiAKKyNkZWZpbmUg YXRvbWljX3JlYWRfZXB0X2VudHJ5KF9fcGVwdGUpICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXAorICAgICggKGVwdF9lbnRyeV90KSB7IC5lcHRlID0gYXRvbWljX3JlYWQ2NCgm KF9fcGVwdGUpLT5lcHRlKSB9ICkKKyNkZWZpbmUgYXRvbWljX3dyaXRlX2VwdF9lbnRyeShf X3BlcHRlLCBfX2VwdGUpICAgICAgICAgICAgICAgICAgICAgXAorICAgIGF0b21pY193cml0 ZTY0KCYoX19wZXB0ZSktPmVwdGUsIChfX2VwdGUpLmVwdGUpCisKICNkZWZpbmUgaXNfZXB0 ZV9wcmVzZW50KGVwdF9lbnRyeSkgICAgICAoKGVwdF9lbnRyeSktPmVwdGUgJiAweDcpCiAj ZGVmaW5lIGlzX2VwdGVfc3VwZXJwYWdlKGVwdF9lbnRyeSkgICAgKChlcHRfZW50cnkpLT5z cCkKIApAQCAtMjIyLDcgKzIyNyw3IEBACiAgICAgLyogZXB0X25leHRfbGV2ZWwoKSBpcyBj YWxsZWQgKHNvbWV0aW1lcykgd2l0aG91dCBhIGxvY2suICBSZWFkCiAgICAgICogdGhlIGVu dHJ5IG9uY2UsIGFuZCBhY3Qgb24gdGhlICJjYWNoZWQiIGVudHJ5IGFmdGVyIHRoYXQgdG8K ICAgICAgKiBhdm9pZCByYWNlcy4gKi8KLSAgICBlPSplcHRfZW50cnk7CisgICAgZSA9IGF0 b21pY19yZWFkX2VwdF9lbnRyeShlcHRfZW50cnkpOwogCiAgICAgaWYgKCAhaXNfZXB0ZV9w cmVzZW50KCZlKSApCiAgICAgewpAQCAtMjM1LDcgKzI0MCw3IEBACiAgICAgICAgIGlmICgg IWVwdF9zZXRfbWlkZGxlX2VudHJ5KHAybSwgZXB0X2VudHJ5KSApCiAgICAgICAgICAgICBy ZXR1cm4gR1VFU1RfVEFCTEVfTUFQX0ZBSUxFRDsKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgZT0qZXB0X2VudHJ5OyAvKiBSZWZyZXNoICovCisgICAgICAgICAgICBlID0gYXRvbWlj X3JlYWRfZXB0X2VudHJ5KGVwdF9lbnRyeSk7IC8qIFJlZnJlc2ggKi8KICAgICB9CiAKICAg ICAvKiBUaGUgb25seSB0aW1lIHNwIHdvdWxkIGJlIHNldCBoZXJlIGlzIGlmIHdlIGhhZCBo aXQgYSBzdXBlcnBhZ2UgKi8KQEAgLTMxNyw2ICszMjIsNyBAQAogICAgIGlmICggaSA9PSB0 YXJnZXQgKQogICAgIHsKICAgICAgICAgLyogV2UgcmVhY2hlZCB0aGUgdGFyZ2V0IGxldmVs LiAqLworICAgICAgICBlcHRfZW50cnlfdCBuZXdfZW50cnkgPSB7IC5lcHRlID0gMCB9Owog CiAgICAgICAgIC8qIE5vIG5lZWQgdG8gZmx1c2ggaWYgdGhlIG9sZCBlbnRyeSB3YXNuJ3Qg dmFsaWQgKi8KICAgICAgICAgaWYgKCAhaXNfZXB0ZV9wcmVzZW50KGVwdF9lbnRyeSkgKQpA QCAtMzI1LDggKzMzMSw2IEBACiAgICAgICAgIGlmICggbWZuX3ZhbGlkKG1mbl94KG1mbikp IHx8IGRpcmVjdF9tbWlvIHx8IHAybV9pc19wYWdlZChwMm10KSB8fAogICAgICAgICAgICAg IChwMm10ID09IHAybV9yYW1fcGFnaW5nX2luX3N0YXJ0KSApCiAgICAgICAgIHsKLSAgICAg ICAgICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAwIH07Ci0KICAgICAg ICAgICAgIC8qIENvbnN0cnVjdCB0aGUgbmV3IGVudHJ5LCBhbmQgdGhlbiB3cml0ZSBpdCBv bmNlICovCiAgICAgICAgICAgICBuZXdfZW50cnkuZW10ID0gZXB0ZV9nZXRfZW50cnlfZW10 KHAybS0+ZG9tYWluLCBnZm4sIG1mbiwgJmlwYXQsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkaXJlY3RfbW1pbyk7CkBAIC0zNDEsMTEgKzM0 NSw5IEBACiAgICAgICAgICAgICAgICAgbmV3X2VudHJ5Lm1mbiA9IG1mbl94KG1mbik7CiAK ICAgICAgICAgICAgIGVwdF9wMm1fdHlwZV90b19mbGFncygmbmV3X2VudHJ5LCBwMm10KTsK KyAgICAgICAgfQogCi0gICAgICAgICAgICBlcHRfZW50cnktPmVwdGUgPSBuZXdfZW50cnku ZXB0ZTsKLSAgICAgICAgfQotICAgICAgICBlbHNlCi0gICAgICAgICAgICBlcHRfZW50cnkt PmVwdGUgPSAwOworICAgICAgICBhdG9taWNfd3JpdGVfZXB0X2VudHJ5KGVwdF9lbnRyeSwg bmV3X2VudHJ5KTsKICAgICB9CiAgICAgZWxzZQogICAgIHsKQEAgLTM1NSw3ICszNTcsNyBA QAogCiAgICAgICAgIEFTU0VSVChpc19lcHRlX3N1cGVycGFnZShlcHRfZW50cnkpKTsKIAot ICAgICAgICBzcGxpdF9lcHRfZW50cnkgPSAqZXB0X2VudHJ5OworICAgICAgICBzcGxpdF9l cHRfZW50cnkgPSBhdG9taWNfcmVhZF9lcHRfZW50cnkoZXB0X2VudHJ5KTsKIAogICAgICAg ICBpZiAoICFlcHRfc3BsaXRfc3VwZXJfcGFnZShwMm0sICZzcGxpdF9lcHRfZW50cnksIGks IHRhcmdldCkgKQogICAgICAgICB7CkBAIC0zNjUsNyArMzY3LDcgQEAKIAogICAgICAgICAv KiBub3cgaW5zdGFsbCB0aGUgbmV3bHkgc3BsaXQgZXB0IHN1Yi10cmVlICovCiAgICAgICAg IC8qIE5COiBwbGVhc2UgbWFrZSBzdXJlIGRvbWlhbiBpcyBwYXVzZWQgYW5kIG5vIGluLWZs eSBWVC1kIERNQS4gKi8KLSAgICAgICAgKmVwdF9lbnRyeSA9IHNwbGl0X2VwdF9lbnRyeTsK KyAgICAgICAgYXRvbWljX3dyaXRlX2VwdF9lbnRyeShlcHRfZW50cnksIHNwbGl0X2VwdF9l bnRyeSk7CiAKICAgICAgICAgLyogdGhlbiBtb3ZlIHRvIHRoZSBsZXZlbCB3ZSB3YW50IHRv IG1ha2UgcmVhbCBjaGFuZ2VzICovCiAgICAgICAgIGZvciAoIDsgaSA+IHRhcmdldDsgaS0t ICkKQEAgLTM5MSw3ICszOTMsNyBAQAogCiAgICAgICAgIGVwdF9wMm1fdHlwZV90b19mbGFn cygmbmV3X2VudHJ5LCBwMm10KTsKIAotICAgICAgICBlcHRfZW50cnktPmVwdGUgPSBuZXdf ZW50cnkuZXB0ZTsKKyAgICAgICAgYXRvbWljX3dyaXRlX2VwdF9lbnRyeShlcHRfZW50cnks IG5ld19lbnRyeSk7CiAgICAgfQogCiAgICAgLyogVHJhY2sgdGhlIGhpZ2hlc3QgZ2ZuIGZv ciB3aGljaCB3ZSBoYXZlIGV2ZXIgaGFkIGEgdmFsaWQgbWFwcGluZyAqLwo= --B_3375376497_47408197 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --B_3375376497_47408197--