From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] libxl: Specify the target ram size to Qemu (new) when calling it Date: Thu, 06 Jan 2011 14:35:04 +0000 Message-ID: References: <19749.53621.856800.183479@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19749.53621.856800.183479@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , anthony.perard@citrix.com Cc: Xen Devel List-Id: xen-devel@lists.xenproject.org On 06/01/2011 14:28, "Ian Jackson" wrote: > anthony.perard@citrix.com writes ("[Xen-devel] [PATCH] libxl: Specify the > target ram size to Qemu (new) when calling it"): >> This patch adds target_ram in device_model_info structure, to be used in >> libxl_build_device_model_args_new. Qemu upstream needs to know about it. > > I have applied this patch, thanks. > > I'm just a little concerned, though: can you explain _why_ qemu > upstream needs to know the target ram size ? Qemu used to be responsible for initialising BIOS info tables, including memory size information such as e820, in lieu of the virtual BIOS doing it. I ripped all that out from our diverged tree, and put it in hvmloader/rombios, but maybe they still do it in upstream qemu. I think it would be harmless if so, since hvmloader/rombios will overwrite/ignore. -- Keir > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel