From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller Date: Mon, 07 Mar 2011 15:15:44 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="B_3382355748_138047025" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3382355748_138047025 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit On 07/03/2011 15:05, "Keir Fraser" wrote: > On 07/03/2011 11:26, "Tim Deegan" wrote: > >> (dump_execution_state()) as its own bug-trap. >> >> This is needed to compile xen with clang, which can't handle using a >> function name in an asm immediate. > > Actually run_in_exception_handler() does have another user, in ns16550.c. > Although non-essential, it makes the 'd' debug key much more useful when > running the UART in polled mode. > > So I suggest we keep run_in_exception_handler but modify it to pass the > function pointer in (say) rAX. Like the attached patch (against latest tip). -- Keir > I think we won't easily be able to use > BUG_STR() logic but r_i_e_h is only used (directly or indirectly) in a few > places so the BUG_STR optimisation is unimportant. The only other > disadvantage is that rAX is less interesting in the state dump, but any > value the function pointer displaces can still be found in the stack dump, > albeit with likely a little extra effort. > > Sound good? > > -- Keir > >> Signed-off-by: Tim Deegan >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > --B_3382355748_138047025 Content-type: application/octet-stream; name="00-reintroduce-run-in-exc-handler" Content-disposition: attachment; filename="00-reintroduce-run-in-exc-handler" Content-transfer-encoding: base64 ZGlmZiAtciAwNzZiNjNiNzRjZjYgeGVuL2FyY2gveDg2L3RyYXBzLmMKLS0tIGEveGVuL2Fy Y2gveDg2L3RyYXBzLmMJTW9uIE1hciAwNyAxMTozNDowOSAyMDExICswMDAwCisrKyBiL3hl bi9hcmNoL3g4Ni90cmFwcy5jCU1vbiBNYXIgMDcgMTU6MTQ6MjIgMjAxMSArMDAwMApAQCAt OTA5LDkgKzkwOSwxMCBAQAogCiAgICAgaWQgPSBidWcuaWQgJiAzOwogCi0gICAgaWYgKCBp ZCA9PSBCVUdGUkFNRV9zdGF0ZSApCisgICAgaWYgKCBpZCA9PSBCVUdGUkFNRV9ydW5fZm4g KQogICAgIHsKLSAgICAgICAgc2hvd19leGVjdXRpb25fc3RhdGUocmVncyk7CisgICAgICAg IHZvaWQgKCpmbikoc3RydWN0IGNwdV91c2VyX3JlZ3MgKikgPSAodm9pZCAqKXJlZ3MtPmVh eDsKKyAgICAgICAgKCpmbikocmVncyk7CiAgICAgICAgIHJlZ3MtPmVpcCA9ICh1bnNpZ25l ZCBsb25nKWVpcDsKICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtciAwNzZiNjNiNzRj ZjYgeGVuL2luY2x1ZGUvYXNtLXg4Ni9idWcuaAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2 L2J1Zy5oCU1vbiBNYXIgMDcgMTE6MzQ6MDkgMjAxMSArMDAwMAorKysgYi94ZW4vaW5jbHVk ZS9hc20teDg2L2J1Zy5oCU1vbiBNYXIgMDcgMTU6MTQ6MjIgMjAxMSArMDAwMApAQCAtMTMs MTUgKzEzLDE2IEBACiAgICAgdW5zaWduZWQgc2hvcnQgaWQ7IC8qIEJVR0ZSQU1FXz8/PyAq LwogfSBfX2F0dHJpYnV0ZV9fKChwYWNrZWQpKTsKIAotI2RlZmluZSBCVUdGUkFNRV9zdGF0 ZSAgMAorI2RlZmluZSBCVUdGUkFNRV9ydW5fZm4gMAogI2RlZmluZSBCVUdGUkFNRV93YXJu ICAgMQogI2RlZmluZSBCVUdGUkFNRV9idWcgICAgMgogI2RlZmluZSBCVUdGUkFNRV9hc3Nl cnQgMwogCi0jZGVmaW5lIGR1bXBfZXhlY3V0aW9uX3N0YXRlKCkgICAgICAgICAgICAgICAg ICAgICBcCisjZGVmaW5lIHJ1bl9pbl9leGNlcHRpb25faGFuZGxlcihmbikgICAgICAgICAg ICAgICBcCiAgICAgYXNtIHZvbGF0aWxlICggICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCiAgICAgICAgICJ1ZDIgOyByZXQgJTAiICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCi0gICAgICAgIDogOiAiaSIgKEJVR0ZSQU1FX3N0YXRlKSApCisgICAgICAgIDog OiAiaSIgKEJVR0ZSQU1FX3J1bl9mbiksICAgICAgICAgICAgICAgICBcCisgICAgICAgICAg ICAiYSIgKGZuKSApCiAKICNkZWZpbmUgV0FSTigpICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFwKICAgICBhc20gdm9sYXRpbGUgKCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFwKZGlmZiAtciAwNzZiNjNiNzRjZjYgeGVuL2luY2x1ZGUvYXNtLXg4 Ni9wcm9jZXNzb3IuaAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3Byb2Nlc3Nvci5oCU1v biBNYXIgMDcgMTE6MzQ6MDkgMjAxMSArMDAwMAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2 L3Byb2Nlc3Nvci5oCU1vbiBNYXIgMDcgMTU6MTQ6MjIgMjAxMSArMDAwMApAQCAtNTQyLDYg KzU0Miw3IEBACiB2b2lkIHNob3dfc3RhY2tfb3ZlcmZsb3codW5zaWduZWQgaW50IGNwdSwg dW5zaWduZWQgbG9uZyBlc3ApOwogdm9pZCBzaG93X3JlZ2lzdGVycyhzdHJ1Y3QgY3B1X3Vz ZXJfcmVncyAqcmVncyk7CiB2b2lkIHNob3dfZXhlY3V0aW9uX3N0YXRlKHN0cnVjdCBjcHVf dXNlcl9yZWdzICpyZWdzKTsKKyNkZWZpbmUgZHVtcF9leGVjdXRpb25fc3RhdGUoKSBydW5f aW5fZXhjZXB0aW9uX2hhbmRsZXIoc2hvd19leGVjdXRpb25fc3RhdGUpCiB2b2lkIHNob3df cGFnZV93YWxrKHVuc2lnbmVkIGxvbmcgYWRkcik7CiBhc21saW5rYWdlIHZvaWQgZmF0YWxf dHJhcChpbnQgdHJhcG5yLCBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncyk7CiAK --B_3382355748_138047025 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --B_3382355748_138047025--