From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@novell.com>, Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions
Date: Tue, 08 Mar 2011 16:29:20 +0000 [thread overview]
Message-ID: <C99C09E0.14520%keir.xen@gmail.com> (raw)
In-Reply-To: <4D761A880200007800035223@vpn.id2.novell.com>
On 08/03/2011 11:01, "Jan Beulich" <JBeulich@novell.com> wrote:
>>>> On 08.03.11 at 11:44, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>> At 09:27 +0000 on 08 Mar (1299576427), Jan Beulich wrote:
>>>>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> @@ -2678,7 +2678,7 @@ x86_emulate(
>>>> emulate_fpu_insn_memsrc("fiaddl", src.val);
>>>> break;
>>>> case 1: /* fimul m64i */
>>>> - emulate_fpu_insn_memsrc("fimul", src.val);
>>>> + emulate_fpu_insn_memsrc("fimuls", src.val);
>>>
>>> fimull.
>>
>> fimuls is what the previous code generates, but it does look like that
>> was wrong. I'll fix it, thanks.
>
> And perhaps that fix by itself should go into 4.1/4.0 too.
Done. Also I fixed the comments to read 'm32i' and also noted and fixed
src.bytes=ea.bytes=4 rather than 8.
-- Keir
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-03-08 16:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 11:26 [PATCH 0 of 8] Allow building xen with clang/llvm Tim Deegan
2011-03-07 11:26 ` [PATCH 1 of 8] x86: make spinlock's 16-bit asm operand explicitly 16-bit Tim Deegan
2011-03-07 11:26 ` [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions Tim Deegan
2011-03-08 9:27 ` Jan Beulich
2011-03-08 10:44 ` Tim Deegan
2011-03-08 11:01 ` Jan Beulich
2011-03-08 16:29 ` Keir Fraser [this message]
2011-03-07 11:26 ` [PATCH 3 of 8] x86: redefine a few empty macros as explicit nops Tim Deegan
2011-03-07 11:26 ` [PATCH 4 of 8] xen: adjust cpumask initializers to suit clang's incomplete gccisms Tim Deegan
2011-03-07 11:26 ` [PATCH 5 of 8] credit2: remove two nested functions, replacing them with static ones Tim Deegan
2011-03-07 15:22 ` George Dunlap
2011-03-07 11:26 ` [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller Tim Deegan
2011-03-07 15:05 ` Keir Fraser
2011-03-07 15:15 ` Keir Fraser
2011-03-07 15:38 ` Tim Deegan
2011-03-07 15:44 ` Keir Fraser
2011-03-07 15:49 ` Keir Fraser
2011-03-07 15:56 ` Tim Deegan
2011-03-07 16:00 ` Keir Fraser
2011-03-07 16:06 ` Tim Deegan
2011-03-07 11:26 ` [PATCH 7 of 8] x86: redefine REX64_PREFIX for clang, which doesn't like 'rex64/' Tim Deegan
2011-03-07 11:26 ` [PATCH 8 of 8] xen: add "clang=y" option to build Xen with clang/llvm instead of gcc Tim Deegan
2011-03-07 14:54 ` Ian Campbell
2011-03-07 16:29 ` Tim Deegan
2011-03-07 17:01 ` Keir Fraser
2011-03-08 10:29 ` Tim Deegan
2011-03-08 10:00 ` Ian Campbell
2011-03-07 12:03 ` [PATCH 0 of 8] Allow building xen with clang/llvm Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C99C09E0.14520%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=Tim.Deegan@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).