From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH 2 of 8] x86: add explicit size suffixes  to
	some assembly instructions
Date: Tue, 08 Mar 2011 16:29:20 +0000
Message-ID: <C99C09E0.14520%keir.xen@gmail.com>
References: <4D761A880200007800035223@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D761A880200007800035223@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>, Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 08/03/2011 11:01, "Jan Beulich" <JBeulich@novell.com> wrote:

>>>> On 08.03.11 at 11:44, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>> At 09:27 +0000 on 08 Mar (1299576427), Jan Beulich wrote:
>>>>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> @@ -2678,7 +2678,7 @@ x86_emulate(
>>>>                 emulate_fpu_insn_memsrc("fiaddl", src.val);
>>>>                 break;
>>>>             case 1: /* fimul m64i */
>>>> -                emulate_fpu_insn_memsrc("fimul", src.val);
>>>> +                emulate_fpu_insn_memsrc("fimuls", src.val);
>>> 
>>> fimull.
>> 
>> fimuls is what the previous code generates, but it does look like that
>> was wrong.  I'll fix it, thanks.
> 
> And perhaps that fix by itself should go into 4.1/4.0 too.

Done. Also I fixed the comments to read 'm32i' and also noted and fixed
src.bytes=ea.bytes=4 rather than 8.

 -- Keir

> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel