From: Keir Fraser <keir.xen@gmail.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Przywara, Andre" <Andre.Przywara@amd.com>
Subject: Re: [Patch] remove unneeded test for cpu in cpupool
Date: Wed, 16 Mar 2011 10:13:42 +0000 [thread overview]
Message-ID: <C9A63DD6.14E2D%keir.xen@gmail.com> (raw)
In-Reply-To: <4D8059DD.20907@ts.fujitsu.com>
On 16/03/2011 06:34, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:
> Hi,
>
> attached patch removes an unneeded check in vcpu_migrate().
>
> Andre, could you please give it a try on your 48 core machine with
>
> xl cpupool-numa-split
>
> I'd like to make sure the check is really not needed. On my machines it worked
> okay, but your machine seems to trigger races more easily.
Could you BUG_ON failing this test when we exit the retry loop? It seems a
suitable loop post-condition.
-- Keir
>
> Juergen
next prev parent reply other threads:[~2011-03-16 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 6:34 [Patch] remove unneeded test for cpu in cpupool Juergen Gross
2011-03-16 10:13 ` Keir Fraser [this message]
2011-03-16 10:36 ` Juergen Gross
2011-03-16 11:14 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9A63DD6.14E2D%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=Andre.Przywara@amd.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).