From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [Patch] remove unneeded test for cpu in cpupool
Date: Wed, 16 Mar 2011 10:13:42 +0000
Message-ID: <C9A63DD6.14E2D%keir.xen@gmail.com>
References: <4D8059DD.20907@ts.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D8059DD.20907@ts.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Juergen Gross <juergen.gross@ts.fujitsu.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Przywara, Andre" <Andre.Przywara@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 16/03/2011 06:34, "Juergen Gross" <juergen.gross@ts.fujitsu.com> wrote:

> Hi,
> 
> attached patch removes an unneeded check in vcpu_migrate().
> 
> Andre, could you please give it a try on your 48 core machine with
> 
> xl cpupool-numa-split
> 
> I'd like to make sure the check is really not needed. On my machines it worked
> okay, but your machine seems to trigger races more easily.

Could you BUG_ON failing this test when we exit the retry loop? It seems a
suitable loop post-condition.

 -- Keir

> 
> Juergen