From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@novell.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: xen-unstable: build fails
Date: Thu, 17 Mar 2011 10:55:30 +0000 [thread overview]
Message-ID: <C9A79922.14F9A%keir.xen@gmail.com> (raw)
In-Reply-To: <4D81F4F702000078000370BB@vpn.id2.novell.com>
On 17/03/2011 10:48, "Jan Beulich" <JBeulich@novell.com> wrote:
>> As short time measure this seems to be okay.
>>
>> On the long run I'd prefer to use absolute paths only. Otherwise you've
>> always a risk to use something from outside the intended build environment.
>>
>> XEN_ROOT = $(abspath ../..)
>>
>> seems not too hard to use instead of
>>
>> XEN_ROOT = ../..
>
> Except that make 3.80 doesn't support this, and that make version
> is - to my knowledge - still in quite wide spread use. But that can
> probably be overcome with a fallback implementation (which newer
> make just wouldn't use).
It has CURDIR, so we can just use that. Which is what I've done. It's also
cleaned up some not-nice bit of build-fu which were prefixing a relative
XEN_ROOT with arbitrary extra ../'s to "make things work".
-- Keir
next prev parent reply other threads:[~2011-03-17 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 13:50 xen-unstable: build fails Juergen Gross
2011-03-16 14:45 ` Juergen Gross
2011-03-16 16:50 ` Keir Fraser
2011-03-17 5:52 ` Juergen Gross
2011-03-17 8:11 ` Keir Fraser
2011-03-17 8:59 ` Juergen Gross
2011-03-17 10:13 ` Jan Beulich
2011-03-17 10:29 ` Juergen Gross
2011-03-17 10:48 ` Jan Beulich
2011-03-17 10:55 ` Keir Fraser [this message]
2011-03-17 10:36 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2010-05-05 5:46 xen-unstable " Juergen Gross
2010-05-05 6:31 ` Shriram R
2010-05-05 9:00 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9A79922.14F9A%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).