From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: serial console driver using release_irq()/setup_irq() on suspend/resume
Date: Thu, 17 Mar 2011 17:01:25 +0000 [thread overview]
Message-ID: <C9A7EEE5.15008%keir.xen@gmail.com> (raw)
In-Reply-To: <4D8248D3020000780003720C@vpn.id2.novell.com>
On 17/03/2011 16:45, "Jan Beulich" <JBeulich@novell.com> wrote:
> Keir,
>
> is there any particular reason this is being done this way, other than
> having made the change in 15259:35e38c9048c8 very simple? I'm
> asking because in general, with no modules, Xen ought to not need
> setup_irq() post-init (for release_irq() the serial driver is actually the
> only consumer), and after fiddling with request_irq() callers this is
> now the only one needing the function to be in .text.
I expect it was done that way for simplicity, so that resume looks like
boot-time init. Feel free to mess with it and make a more customised
streamlined resume path.
-- Keir
> Jan
>
prev parent reply other threads:[~2011-03-17 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:45 serial console driver using release_irq()/setup_irq() on suspend/resume Jan Beulich
2011-03-17 17:01 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9A7EEE5.15008%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).