* serial console driver using release_irq()/setup_irq() on suspend/resume
@ 2011-03-17 16:45 Jan Beulich
2011-03-17 17:01 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2011-03-17 16:45 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel@lists.xensource.com
Keir,
is there any particular reason this is being done this way, other than
having made the change in 15259:35e38c9048c8 very simple? I'm
asking because in general, with no modules, Xen ought to not need
setup_irq() post-init (for release_irq() the serial driver is actually the
only consumer), and after fiddling with request_irq() callers this is
now the only one needing the function to be in .text.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: serial console driver using release_irq()/setup_irq() on suspend/resume
2011-03-17 16:45 serial console driver using release_irq()/setup_irq() on suspend/resume Jan Beulich
@ 2011-03-17 17:01 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2011-03-17 17:01 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel@lists.xensource.com
On 17/03/2011 16:45, "Jan Beulich" <JBeulich@novell.com> wrote:
> Keir,
>
> is there any particular reason this is being done this way, other than
> having made the change in 15259:35e38c9048c8 very simple? I'm
> asking because in general, with no modules, Xen ought to not need
> setup_irq() post-init (for release_irq() the serial driver is actually the
> only consumer), and after fiddling with request_irq() callers this is
> now the only one needing the function to be in .text.
I expect it was done that way for simplicity, so that resume looks like
boot-time init. Feel free to mess with it and make a more customised
streamlined resume path.
-- Keir
> Jan
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-17 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 16:45 serial console driver using release_irq()/setup_irq() on suspend/resume Jan Beulich
2011-03-17 17:01 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).