From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: serial console driver using
 release_irq()/setup_irq() on suspend/resume
Date: Thu, 17 Mar 2011 17:01:25 +0000
Message-ID: <C9A7EEE5.15008%keir.xen@gmail.com>
References: <4D8248D3020000780003720C@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D8248D3020000780003720C@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 17/03/2011 16:45, "Jan Beulich" <JBeulich@novell.com> wrote:

> Keir,
> 
> is there any particular reason this is being done this way, other than
> having made the change in 15259:35e38c9048c8 very simple? I'm
> asking because in general, with no modules, Xen ought to not need
> setup_irq() post-init (for release_irq() the serial driver is actually the
> only consumer), and after fiddling with request_irq() callers this is
> now the only one needing the function to be in .text.

I expect it was done that way for simplicity, so that resume looks like
boot-time init. Feel free to mess with it and make a more customised
streamlined resume path.

 -- Keir

> Jan
>