From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: Jinsong Liu <jinsong.liu@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume
Date: Fri, 18 Mar 2011 17:11:51 +0000 [thread overview]
Message-ID: <C9A942D7.150C2%keir.xen@gmail.com> (raw)
In-Reply-To: <4D8397FA0200007800037494@vpn.id2.novell.com>
On 18/03/2011 16:35, "Jan Beulich" <JBeulich@novell.com> wrote:
>> if ( !early_init_done ) {
>> BUG_ON(smp_processor_id() != 0);
>> ...
>> early_init_done = 1;
>> }
>>
>> It's clearer anyway -- we're simply protecting one-time-only early-boot-time
>> initialisation stuff.
>
> What's wrong with doing the protection by passing down the
> necessary information?
Hm, yes, fair enough, I'll apply it.
-- Keir
next prev parent reply other threads:[~2011-03-18 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 15:07 [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume Jan Beulich
2011-03-18 15:43 ` Keir Fraser
2011-03-18 16:35 ` Jan Beulich
2011-03-18 17:11 ` Keir Fraser [this message]
2011-03-19 15:53 ` Liu, Jinsong
2011-03-19 22:20 ` Keir Fraser
2011-03-21 8:22 ` Jan Beulich
2011-03-21 13:18 ` Liu, Jinsong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C9A942D7.150C2%keir.xen@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@novell.com \
--cc=jinsong.liu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).