From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86/mce: CPU notifiers must not be registered a second time during resume Date: Fri, 18 Mar 2011 17:11:51 +0000 Message-ID: References: <4D8397FA0200007800037494@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D8397FA0200007800037494@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: Jinsong Liu , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 18/03/2011 16:35, "Jan Beulich" wrote: >> if ( !early_init_done ) { >> BUG_ON(smp_processor_id() != 0); >> ... >> early_init_done = 1; >> } >> >> It's clearer anyway -- we're simply protecting one-time-only early-boot-time >> initialisation stuff. > > What's wrong with doing the protection by passing down the > necessary information? Hm, yes, fair enough, I'll apply it. -- Keir