xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@novell.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: arch_set_info_guest() producing inconsistent state on x86?
Date: Tue, 29 Mar 2011 13:01:28 +0100	[thread overview]
Message-ID: <C9B788A8.158C5%keir.xen@gmail.com> (raw)
In-Reply-To: <4D91E2820200007800038D68@vpn.id2.novell.com>

On 29/03/2011 12:45, "Jan Beulich" <JBeulich@novell.com> wrote:

>> It's probably used by debuggers running in dom0? Also see
>> modify_returncode() in libxc/xc_resume.c -- so it's used on suspend resume
>> in the failure case.
>> 
>> I doubt anything other than GPRs are ever modified after first
>> initialisation.
> 
> So should we then perhaps make the function check the bits
> it doesn't really update match what is in place already?

I suppose it would be nice. I can't say I care much one way or the other.

 -- Keir

  reply	other threads:[~2011-03-29 12:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  8:01 arch_set_info_guest() producing inconsistent state on x86? Jan Beulich
2011-03-29  9:59 ` Keir Fraser
2011-03-29 11:45   ` Jan Beulich
2011-03-29 12:01     ` Keir Fraser [this message]
2011-03-29 12:05       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C9B788A8.158C5%keir.xen@gmail.com \
    --to=keir.xen@gmail.com \
    --cc=JBeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).