From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: arch_set_info_guest() producing inconsistent state on
	x86?
Date: Tue, 29 Mar 2011 13:01:28 +0100
Message-ID: <C9B788A8.158C5%keir.xen@gmail.com>
References: <4D91E2820200007800038D68@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D91E2820200007800038D68@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 29/03/2011 12:45, "Jan Beulich" <JBeulich@novell.com> wrote:

>> It's probably used by debuggers running in dom0? Also see
>> modify_returncode() in libxc/xc_resume.c -- so it's used on suspend resume
>> in the failure case.
>> 
>> I doubt anything other than GPRs are ever modified after first
>> initialisation.
> 
> So should we then perhaps make the function check the bits
> it doesn't really update match what is in place already?

I suppose it would be nice. I can't say I care much one way or the other.

 -- Keir