From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 6/6] passthrough: use domain pirq as index of struct hvm_irq_dpci's hvm_timer array Date: Tue, 05 Apr 2011 13:05:38 +0100 Message-ID: References: <4D9AEDDA0200007800039F5B@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D9AEDDA0200007800039F5B@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 05/04/2011 09:24, "Jan Beulich" wrote: > Such space saving wouldn't, however, suffice to generally get the > respective allocation sizes here to below PAGE_SIZE, not even when > converting the array of structures into an array of pointers to > structures. Whether a multi-level lookup mechanism would make sense here > is questionable, as it can be expected that for other than Dom0 (which > isn't hvm, and hence shouldn't use these data structures - see > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg02004.html) > only very few entries would commonly be used here. An obvious alternative > would be to use rb or radix trees (both currently only used in tmem). Yes it would be preferable to be using radix trees much more widely. -- Keir