From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup)
Date: Wed, 13 Apr 2011 14:06:43 +0100
Message-ID: <C9CB5E73.1644B%keir.xen@gmail.com>
References: <4DA57C86.7000902@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4DA57C86.7000902@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> Cleanup for ASID emulation:
> - Use C99 integer types for asid numbers

> - asid.c: consistently use 'v' instead of 'curr'

On what planet is that an improvement??

We use 'curr' as a convenient idiom to represent cached current. Whereas 'v'
is supposed to represent an arbitrary vcpu.

I know it costs three extra characters per use, but it does make code easier
to understand.

 -- Keir

> - Introduce svm_invlpga() used in ASID emulation patch
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>